Gate readiness probes #6707
Merged
Gate readiness probes #6707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Foremost, make sure the tests don't run for 25 seconds, but rather just 4 2. Remove the unneeded method 3. More to come
knative-prow-robot
added
size/L
|
The following is the coverage report on the affected files.
|
vagababov
force-pushed
the
20200131-clean-readiness
branch
from
a0fedd2
to
04b3ad4
Compare
|
Fixes #6680 |
|
The following jobs failed:
Automatically retrying due to test flakiness... |
vagababov
force-pushed
the
20200131-clean-readiness
branch
from
04b3ad4
to
cc0777d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims at limiting only a single readiness probe at a time.
We noticed a problem with the activator daemon set that when a new pod comes to life and is probed by say 30 probes at the same time (the size of our load benchmark cluster), the user container can be overwhelmed and fails the probes.
So this basically does gating of the readiness probes.
If a probe is already in progress, we attach to its result. Otherwise create a new one.
There's more details due to the possible races, so the code feels complex, but in essence it's simple :)
/assign @markusthoemmes mattmoor