Add support for Labels in DomainTemplate #7647
Conversation
knative-prow-robot
added
the
size/M
There was a problem hiding this comment.
@duglin: 0 warnings.
In response to this:
Allow us to access Labels in the DomainTemplate, similar to how people can
access Annotations. This allows people to create custom URLs via the
template and to choose custom domains in the config-domain configMap via
labels - instead of one via annotations and the other via labels.Signed-off-by: Doug Davis dug@us.ibm.com
/lint
Proposed Changes
- Add support for Labels in DomainTemplate
Release Note
Can now access Labels in the DomainTemplate property in the config-network ConfigMap
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
knative-prow-robot
requested review from
evankanderson,
JRBANCEL and
ZhiminXiang
Allow us to access Labels in the DomainTemplate, similar to how people can access Annotations. This allows people to create custom URLs via the template and to choose custom domains in the config-domain configMap via labels - instead of one via annotations and the other via labels. Signed-off-by: Doug Davis <dug@us.ibm.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: duglin, markusthoemmes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Allow us to access Labels in the DomainTemplate, similar to how people can
access Annotations. This allows people to create custom URLs via the
template and to choose custom domains in the config-domain configMap via
labels - instead of one via annotations and the other via labels.
Signed-off-by: Doug Davis dug@us.ibm.com
/lint
Proposed Changes
Release Note