Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add net-kourier e2e testing #1854

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Add net-kourier e2e testing #1854

merged 1 commit into from
Mar 26, 2020

Conversation

davidor
Copy link
Contributor

@davidor davidor commented Mar 25, 2020 •
edited
Loading

Same as it was done for net-contour (#1835), but this time for net-kourier.

/cc @jmprusi

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 25, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 25, 2020
@davidor
Copy link
Contributor Author

davidor commented Mar 26, 2020

/retest

@chaodaiG
Copy link
Contributor

/lgtm
/approve

Currently presubmit test is broken in test-infra, we'll try to fix it asap in #1858

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2020
@knative-prow-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaodaiG, davidor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2020
@chizhg
Copy link
Member

chizhg commented Mar 26, 2020

/retest

@knative-prow-robot knative-prow-robot merged commit 5c80391 into knative:master Mar 26, 2020
@knative-prow-updater-robot
Copy link
Contributor

Updated prow configs with below files being modified:

  • config/prow/jobs/config.yaml

@davidor davidor deleted the net-kourier-e2e branch March 26, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

@coryrc coryrc Awaiting requested review from coryrc

Assignees

@chaodaiG chaodaiG

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@davidor @chaodaiG @knative-prow-robot @chizhg @knative-prow-updater-robot @googlebot