Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document new contributing process #119

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

Cali0707
Copy link
Member

@Cali0707 Cali0707 commented Mar 11, 2024

Fixes #118

Changes

  • Document that contributors should open a PR with changes
  • Document that final approval occurs in bi weekly meeting

Signed-off-by: Calum Murray <cmurray@redhat.com>
@knative-prow knative-prow bot requested review from Leo6Leo and mmejia02 March 11, 2024 15:16
Copy link

knative-prow bot commented Mar 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 11, 2024
@Cali0707
Copy link
Member Author

/cc @aliok @Leo6Leo @mmejia02 @zainabhusain227

This change was agreed on last week in the WG meeting, any thoughts on the wording of it here?

@Leo6Leo
Copy link
Member

Leo6Leo commented Mar 11, 2024

And one more thing could be added is:
If they want to ping the WG leads for any help, they can use /cc @knative/ux-wg-leads on GitHub.

CONTRIBUTING.md Outdated Show resolved Hide resolved
button design from Figma)
4. The design leads for the working group will leave feedback on the design, and possible ask you to make some changes with comments on the issue.
5. Once the design leads are happy with your design, they will let you know on the issue.
3. Once you have a design you are happy with or that you want feedback on, you will open a Pull Request to this repository with the artifacts included.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have any directories other than designs in this repo. I don't think we need to create them with this PR, but we should have the awareness to organize stuff. As I said, no issues for now.

@aliok
Copy link
Member

aliok commented Mar 11, 2024

LGTM

Co-authored-by: Ali Ok <aliok@redhat.com>
@Leo6Leo
Copy link
Member

Leo6Leo commented Mar 21, 2024

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2024
@knative-prow knative-prow bot merged commit ef6023f into knative:main Mar 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document new PR process
3 participants