-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: modular structure for adding APPS into TalonVoice framework #129
Comments
Long term, I believe the plan is a package management/plugin system in talon of some sort, so starting from a huge repository like this won’t be a thing, fwiw. I’ll definitely consolidate Talon files where possible if/when that’s implemented. I won’t accept all PRs; I am more likely to accept PRs for more specific contexts. The less specific the context, the more selective I’ll be. I generally prefer a flatter folder structure. vscode is probably the direction I’ll slowly move things. I’d like to get rid of the platform subfolders, but that can probably wait until the consolidation. WIP. |
why app/vscode/mac/vscode.talon instead of app/vscode/mac.talon |
so searching for vscode finds everything vscode-related in most any app the other option was which is reasonable. can't remember why I didn't go this way now. :-/ |
I agree with flatter the better |
works for me |
fwiw i think I also prefer the quoted layout over os-specific sub-folders for each app. i also like the move towards relevant |
yeah, i moved the relevant .py for vscode into apps/vscode too, so that's where we're headed. |
Just mentioning this here, since it's technically part of the move towards a new structure. Moving
Though I confirm that it seems to load the |
Edit: scratch this, that looks like something else. I'd run that one by aegis. @fidgetingbits - I believe Talon loads things alphabetically, so that's probably what you're running into. e.g., the apps folder loads like this
|
@fidgetingbits ^ fyi that looks like this issue talonvoice/beta#83, which is fixed in v1365 |
@knausj85 yep that fixed it, thanks for filling that bug. i had no time to actually play around to figure out what the problem was yet. |
The app folder structure as refactored by @knausj85 in bba1b56 for VSCODE is a step in the right direction for maintainability and extending. 🥇
updated from discussions below
I still believe platform differences could be managed in 1 file, reducing the amount of duplicate work in building support for a cross platform app. This will however need extending the talon syntax to enable a line in the talon file to apply or be exempt from a specific platform context.
Additionally, the support, maintenance and monolithic nature of where this repository is heading should at some point be considered.
It seems a huge task for this one repo to hold all commands for all conceivable applications. . It is also conceivable a user does not want a blotted command set but wants to pick and choose modules.
The above structure that was introduced is in my opinion a great step forward. Together with some guidelines it will enable building on top of the great work the core of this repository has introduced with the awesome TalonVoice by @lunixbochs
my intent with this issue is a place holder FEATURE discussion around appropriate structuring
The text was updated successfully, but these errors were encountered: