Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github shortcut support #117

Merged
merged 3 commits into from
Jul 27, 2020
Merged

github shortcut support #117

merged 3 commits into from
Jul 27, 2020

Conversation

fidgetingbits
Copy link
Collaborator

this is stuff I added for github. unfortunately they don't include the actual name github in their title, so currently the window matching has to be tweaked for whatever repo you are using or just enable it across the board. in light of that I just said it as github for now so people can change it if they want. I did contact github and asked them to change it on their website, but I haven't heard anything back

@knausj85
Copy link
Member

knausj85 commented Jun 8, 2020

maybe try something like https://addons.mozilla.org/en-US/firefox/addon/domain-in-title/ ?

@fidgetingbits
Copy link
Collaborator Author

I tried out that out and it works perfectly so I guess in the meantime I'll just to add that url to the title match and add a comment that people will need to use it

@knausj85
Copy link
Member

knausj85 commented Jun 18, 2020

Thanks for giving it a whirl. I think this is a sensible approach for web app stuff - most browsers have some sort of plugin for adding the domain to the title

@knausj85
Copy link
Member

knausj85 commented Jul 1, 2020

FYI I re-arranged the app folder as discussed for #129, and added a 'web' subfolder. Just a note to perhaps move it when we circle back to this one.

e.g.,
https://github.com/knausj85/knausj_talon/blob/master/apps/web/outlook.talon

@fidgetingbits
Copy link
Collaborator Author

cool will do

@fidgetingbits
Copy link
Collaborator Author

has been moved to web now and using the URL

@knausj85
Copy link
Member

Thank you!

@knausj85 knausj85 merged commit d2553d5 into talonhub:master Jul 27, 2020
@fidgetingbits fidgetingbits deleted the github branch August 24, 2020 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants