A couple missing rust commands #918
Conversation
code/create_spoken_forms.py
Outdated
| @@ -1,8 +1,9 @@ | |||
| import itertools | |||
| import re | |||
| from collections import defaultdict | |||
| from collections.abc import Mapping | |||
There was a problem hiding this comment.
What's up with these changes from typing to collections.abc?
There was a problem hiding this comment.
good question. I think my branch may have been out of sync and not up to date. I can put it back.
There was a problem hiding this comment.
Our autoformatter started doing that last week. Apparently as of 3.9 they're starting to deprecate the versions from typing in favour of those from collections.abc
There was a problem hiding this comment.
Yeah, I think this is coming from a new pyupgrade release.
There was a problem hiding this comment.
Looks like this change was made in #921, so if you rebase this change should disappear.
lang/rust/rust.talon
Outdated
| @@ -48,6 +48,7 @@ toggle use: user.code_toggle_libraries() | |||
| ## Simple aliases | |||
| borrow: "&" | |||
| borrow mutable: "&mut " | |||
| state (async | asynchronous): "async " | |||
There was a problem hiding this comment.
I use "a sink" for this, as I found recognition better. Not sure our stance regarding these kind of games to improve recognition tho. cc/ @knausj85 @lunixbochs
There was a problem hiding this comment.
At some point it might be worth adding this under a common tag to make this consistent between languages.
There was a problem hiding this comment.
Fwiw we support this as a keyword in Javascript
RyanRuane
force-pushed
the
slight_rust_additions
branch
from
4f604ed
to
b7f78bb
Compare
|
rebased |
* A couple missing rust commands * Added "a sink" to improve accuracy
* A couple missing rust commands * Added "a sink" to improve accuracy
No description provided.