Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the active state for modifiers within KssStateGenerator #13

Closed
wants to merge 1 commit into from

Conversation

dewski
Copy link

@dewski dewski commented Dec 7, 2011

In my current use of KSS I have modified the Coffeescript to generate the class names for the element's active state that could be useful for others.

@kneath
Copy link
Owner

kneath commented Dec 10, 2011

I realized that I really need to rethink how this javascript works. Notably, there's some problems:

  • No easy way to support a bunch of different pseudo classes
  • Gets confused if there are multiple pseudo-states in one line, like .test:hover, .test.really:hover (only the first will get a rule generated)

So I might see if I can find a more generic way to solve this stuff instead of just adding to the conditional.

@kneath
Copy link
Owner

kneath commented Dec 10, 2011

Ended up fixing this in e2d2453

@kneath kneath closed this Dec 10, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants