-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[#3033] fix: sqlite3 drop/renameColumn() breaks with postProcessRespo…
…nse (#3040) * [#3033] fix: sqlite3 drop/renameColumn() breaks with postProcessResponse * When postProcessResponse is configured, and client.processResponse() returns a Promise (e.g. for custom cases such as sqlite3 dropColumn()), then that Promise is not awaited, but handed to postProcessResponse, which might break is (e.g. with Objection's knexSnakeCaseMappers()). * when reinserting data in the modified table, the rows are now being handled with the "mapped" identifiers (instead of the unmapped) * add tests, fix hasColumn * add hasColumn tests for add mysql + snakeCaseMappers * Improve tests and fix more cases related to processing * Fix SQLite-specific tests * MySQL is not case-sensitive, pg is
- Loading branch information
Showing
7 changed files
with
391 additions
and
175 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.