Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upPort missing in 'ConnectionConfig' TypeScript definition? #3367
Comments
This comment has been minimized.
This comment has been minimized.
Could you create a pr with the fix? |
This comment has been minimized.
This comment has been minimized.
isn't there separate interface for pg config in master, though? |
This comment has been minimized.
This comment has been minimized.
@kibertoad Sure! As for the config interfaces, I only see these: There isn't an interface called |
This comment has been minimized.
This comment has been minimized.
@kibertoad Just submitted a PR for a separate |
This comment has been minimized.
This comment has been minimized.
Released in 0.20.1 |
Environment
Knex version: 0.18.4
Database + version: Postgres 9.5
OS: macOS 10.14
If issue is about TypeScript definitions, tag @lorefnon.
Bug
(I'm opening this issue under the assumption that I'm supposed to use 'ConnectionConfig' to type my PG connection config object. If my assumption is wrong, then there seems to be a missing type definition for Postgres connection config?)
The
pg
library accepts aport
key, and passing theport
key to knex indeed works:but this key is missing in the
ConnectionConfig
interface.