Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors with orWhereJsonPath clause #5020

Closed
jscek opened this issue Feb 11, 2022 · 1 comment · Fixed by #5022
Closed

Errors with orWhereJsonPath clause #5020

jscek opened this issue Feb 11, 2022 · 1 comment · Fixed by #5022
Assignees
@OlivierCavadenti

Comments

@jscek
Copy link
Contributor

jscek commented Feb 11, 2022 •
edited

Environment

Knex version: 1.0.1
Database + version: PostgreSQL 13.3
OS: Windows

Bug

  1. Every use of 'orWhereJsonPath' clause in query causes an error

  2. Undefined column(s):

  3. I've tried to fix this bug in #5011 with adding missing arguments to whereJsonPath call, you can see this change here. I've also added test case that checks it. Although my change fixed queries for postgres and some other DBs, for some dialects (sqlite, mysql) it still didn't work.
@OlivierCavadenti OlivierCavadenti self-assigned this Feb 11, 2022
@OlivierCavadenti
Copy link
Collaborator

Thanks for the report and work, I will investigate soon.

@OlivierCavadenti OlivierCavadenti changed the title orWhereJsonPath Errors with orWhereJsonPath clause Feb 11, 2022
@OlivierCavadenti OlivierCavadenti mentioned this issue Feb 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OlivierCavadenti OlivierCavadenti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix orWhereJsonPath clause OlivierCavadenti/knex
2 participants
@OlivierCavadenti @jscek