Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix orWhereJsonPath clause #5022

Merged
merged 1 commit into from
Feb 13, 2022
Merged

Fix orWhereJsonPath clause #5022

merged 1 commit into from
Feb 13, 2022

Conversation

OlivierCavadenti
Copy link
Collaborator

@kibertoad
Copy link
Collaborator

this is not a breaking change?

@OlivierCavadenti
Copy link
Collaborator Author

this is not a breaking change?

No, a parameter is missing in whereJsonPath so orWhereJsonPath doesn't work.

@kibertoad
Copy link
Collaborator

are types correct?

@OlivierCavadenti
Copy link
Collaborator Author

are types correct?

Yes, interfaces are the same for all 3 functions:

image

@OlivierCavadenti OlivierCavadenti merged commit 600d3c3 into knex:master Feb 13, 2022
@OlivierCavadenti OlivierCavadenti deleted the or-where-jsonpath branch February 13, 2022 14:11
@kibertoad
Copy link
Collaborator

Released in 1.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kibertoad kibertoad kibertoad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors with orWhereJsonPath clause
2 participants
@OlivierCavadenti @kibertoad