Allowed to set default schema from knexfile file #3832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paul4156 Could you add test for this, and also documentation at https://github.com/knex/documentation ? |
|
Also I assume TS types need to be updated in https://github.com/knex/knex/blob/master/types/index.d.ts |
|
OK sure. |
|
@paul4156 Any chance you could finish the PR? |
| @@ -54,6 +54,11 @@ function Knex(config) { | |||
| if (config.userParams) { | |||
| newKnex.userParams = config.userParams; | |||
| } | |||
|
|
|||
| if (config.defaultSchema) { | |||
| newKnex.withSchema(config.defaultSchema); | |||
There was a problem hiding this comment.
As far as I can tell using withSchema on its own like this doesn't prepend the schema. At least not when printing out statements with debug on .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.