Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowed to set default schema from knexfile file #3832

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −0
Open

Allowed to set default schema from knexfile file #3832

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3272cb
Allow to change defaultSchema from knexfile
Apr 27, 2020
133078f
Merge branch 'master' of github.com:healthcarelogic/knex
Apr 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/knex.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,11 @@ function Knex(config) {
if (config.userParams) {
newKnex.userParams = config.userParams;
}

if (config.defaultSchema) {
newKnex.withSchema(config.defaultSchema);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell using withSchema on its own like this doesn't prepend the schema. At least not when printing out statements with debug on .

}

return newKnex;
}

Expand Down