Extract query execution-related code from client #4175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibertoad
commented
Dec 26, 2020
|
|
||
| const { __knexUid, __knexTxId } = connection; | ||
|
|
||
| client.emit('query', Object.assign({ __knexUid, __knexTxId }, queryObject)); |
There was a problem hiding this comment.
I'm not too happy about event emitting and debug logic sneakily being in a method called enrichQueryObject, but it is shared across both cases where we use this method.
If someone feels strongly that it's worth to extract those four lines into a separate reused method and has a good name in mind, I'm open to moving them.
elhigu
approved these changes
Dec 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #4174