materialized CTE support for Postgres #4948
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#4948 related |
Why it's not visible? Should I build something special for integration test? |
| @@ -124,6 +124,20 @@ class Builder extends EventEmitter { | |||
| return this.withWrapped(alias, statementOrColumnList, nothingOrStatement); | |||
| } | |||
|
|
|||
| withMaterialized(alias, statementOrColumnList, nothingOrStatement) { | |||
There was a problem hiding this comment.
You implement the functionnality for all database, but only available PG and Sqlite3, so no need here.
There was a problem hiding this comment.
Do you imply this should be added to PG dialect only?
There was a problem hiding this comment.
it should throw an error on dialects which do not support it. so base method should throw, pg and sqlite should override it to actually do something useful
| @@ -1160,6 +1160,16 @@ class QueryCompiler { | |||
| this.client, | |||
| this.bindingsHolder | |||
| ); | |||
|
|
|||
| let sqlMaterialized = ''; | |||
| const canMaterialized = this.client.config.client === 'pg'; | |||
There was a problem hiding this comment.
we dont do check like this in generic files.
|
Fixed by 6398098 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
knex.withMaterialized('t',knex('users')).from('t')forwith 't' as materialized (select * from users) select * from tand
knex.withNotMaterialized('t',knex('users')).from('t')->with 't' as not materialized (select * from users) select * from thttps://www.postgresql.org/docs/current/queries-with.html#id-1.5.6.12.7
I will add documentation changes if this is approved