Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with bigincrements not working with composite key in MySQL - #5341 #5343

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

davidf84
Copy link
Contributor

@davidf84 davidf84 commented Oct 2, 2022

Fixes issue with bigincrements not working when having a composite keys since the alter table is not present for bigincrements as descriped in #5341 .

Also fixes issue when using bigincrements and the field was not added as a primary key. The below currently fails since logic to handle bigincrements in the primary key function is missing.

knex.schema.createTable("test_table", table => {
        table.primary(['name']);
        table.bigincrements('userId');
        table.string('name');
}

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 92.325% when pulling f4a145d on davidf84:master into d39051f on knex:master.

Copy link
Member

@rluvaton rluvaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rluvaton
Copy link
Member

@kibertoad it's looking good

@kibertoad kibertoad merged commit 770b2f2 into knex:master Nov 29, 2023
@kibertoad
Copy link
Collaborator

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants