Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to stable null-safety. #29

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Conversation

CaramelDunes
Copy link
Contributor

Also remove the DoH parts as this was written for Web support that is never going to work as you cannot send UDP packets in a browser. Hopefully fixes #28.
The Web compatibility indicator should be removed from pub.dev accordingly.

I was also thinking we could let the users resolve the address themselves and pass an InternetAddress instead of a hostname.

@oonid
Copy link
Contributor

oonid commented Mar 3, 2021

Hi @CaramelDunes
some people are actually asking to use this library while they build for the web also.
that's why there's DoH implementation.
so removing the web indicator and DoH would set back this library to some while ago.
About the DoH as "the only option", instead of using condition with InternetAddress.lookup, it's the @knezzz decision, so let's wait for the response.

@CaramelDunes
Copy link
Contributor Author

Unfortunately, DoH is not enough to make this work on the Web. This package actually doesn't work on Web (just tested). NTP is a protocol based on UDP, and thus cannot work in a browser.

@knezzz
Copy link
Owner

knezzz commented Mar 8, 2021

Thanks for PR, I will try to go over it today and test it out, then I'll merge it.
I think removing DoH is good step since it didn't solve any problem but is just creating more problems

@knezzz knezzz merged commit 59794ad into knezzz:master Mar 10, 2021
@awaisdev5765
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPv6 only broken with DoH changes
4 participants