Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rending issue when resizing window #2

Closed
awakenweb opened this issue Feb 21, 2014 · 12 comments
Closed

Rending issue when resizing window #2

awakenweb opened this issue Feb 21, 2014 · 12 comments

Comments

@awakenweb
Copy link

Hi,

I found a bug where the email button can take all the place and let other buttons in minimized state, as you can see in this screenshot.
bug
Sometimes it can be both email and FB buttons that are larger than the others.

This happens on desktop browsers (tested with Chrome 32 on Windows7 and IE11 on Windows7) when you resize the window with the mouse to a small size , and then hit the maximize window button.

Edit: seems to be the same problem as the other opened issue: #1

@ErtugKaya
Copy link

Same here with Chrome 32. When you restore from maximized, sometimes labels are truncated as well.

When you resize browser by dragging, it's all fine.

@dbox
Copy link
Contributor

dbox commented Feb 21, 2014

Thanks @awakenweb & @ErtugKaya. We were seeing this randomly as well but couldn't replicate. On the list!

@g105b
Copy link

g105b commented Feb 21, 2014

Chrome 32 Linux.

Screenshot attached.

notresponsive

@birla
Copy link

birla commented Feb 24, 2014

Facing the same issue, on Chrome 32.0.1700.107 m (Windows 7).

I was able to reproduce it every time by resizing the window using "Windows Key + Arrow". The problem is fixed as soon as the window is resized using the mouse (drag).

@joshuatuscan
Copy link
Collaborator

This only seems to be an issue if you are go from mobile sized where small icon format is applied and use the browsers expand/maximize button to take it all the way to large.

The JS can't seem to keep up with such a fast change and proper button proportions aren't maintained when it reaches it's destination width.

This doesn't appear to be an issue when dragging the window with mouse. Not sure what the fix is at the moment aside from running the sizing functions again once more a couple of milliseconds after all resizing is complete.

@ErtugKaya
Copy link

On resize, you should remove small class from buttons then decide if they should be small. For instance, add

$('.rrssb-buttons li.small').removeClass('small');

first at $(window).resize. This should fix the problem.

@dbox dbox reopened this Feb 25, 2014
@birla
Copy link

birla commented Feb 25, 2014

@joshuatuscan Please look at the screenshot posted by @g105b, where the window is resized into a half from the maximized state. I'm able reproduce the same.

@dbox
Copy link
Contributor

dbox commented Feb 25, 2014

@birla Are you just resizing browser or hitting a full screen button?

@birla
Copy link

birla commented Feb 25, 2014

@dbox I'm resizing the window using "Windows Key + Arrow" (right arrow, resulting in the window occupying half of my screen towards the right side) from a maximized state.

@ErtugKaya
Copy link

I downloaded the source and confirm that

    $(window).resize(function () {
        $('.rrssb-buttons li.small').removeClass('small'); //add this here or in rrssbMagicLayout();
        rrssbMagicLayout(sizeSmallBtns);

        waitForFinalEvent(function(){
            rrssbMagicLayout(sizeSmallBtns);
        }, 100, "finished resizing");
    });

fixes the problem seen in @awakenweb ss. May fix other rendering problems as well, cannot manage to reproduce them today. Please check.

@joshuatuscan
Copy link
Collaborator

I've added your code ErtugKaya. Thanks.

@ErtugKaya
Copy link

You are welcome. Already 900 stars! Keep up the good work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants