Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: $ is not a function #97

Closed
AdamPS opened this issue May 2, 2015 · 3 comments
Closed

TypeError: $ is not a function #97

AdamPS opened this issue May 2, 2015 · 3 comments

Comments

@AdamPS
Copy link
Contributor

AdamPS commented May 2, 2015

Version 1.7.5 commit "Added better calc detection and fallback support" added code that relies on the $ variable rather than the full equivalent jQuery. This breaks best practice as per jQuery documentation http://learn.jquery.com/plugins/basic-plugin-creation/#protecting-the-alias-and-adding-scope. In my case it breaks compatibility with Drupal and https://www.drupal.org/project/rrssb.

@dbox
Copy link
Contributor

dbox commented May 2, 2015

Hey Adam. Thanks. Could you do a pull request?
On Sat, May 2, 2015 at 8:25 AM AdamPS notifications@github.com wrote:

Version 1.7.5 commit "Added better calc detection and fallback support"
added code that relies on the $ variable rather than the full equivalent
jQuery. This breaks best practice as per jQuery documentation
http://learn.jquery.com/plugins/basic-plugin-creation/#protecting-the-alias-and-adding-scope.
In my case it breaks compatibility with Drupal and
https://www.drupal.org/project/rrssb.


Reply to this email directly or view it on GitHub
#97.

@AdamPS
Copy link
Contributor Author

AdamPS commented May 2, 2015

Hi thanks for a quick response. Sorry I don't use Git/GitHub, and have limited jQuery knowledge (just did a bunch of searches to figure out the above). I haven't fixed the bug myself, I just went back to the older version. I'm happy to try to help out if there something I can do bearing the above in mind. E.g. I can test a new version of the file.

@AdamPS
Copy link
Contributor Author

AdamPS commented May 3, 2015

Fix works for me, thanks very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants