Fixed memory leak of previousContents when tracking array changes and disposing the subscription #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The observableArray did leak the last value held by the observable when subscribing for array change events, and then disposing the subscription. The vlaue was being held by the closure held by the arrayChangeSubscription. Setting it to null allows the GC to collect the closure and the previousContents variable. This commit fixes knockout#2216
|
Looks good. Thanks. |
|
I must be one of the few that shudder at if statements without brackets ;-) |
|
@codymullins Knockout is inconsistent regarding braces, but I've been trying to make sure all new code uses them. @decden Can you add the braces? |
brianmhunt
added a commit
to knockout/tko.observable
that referenced
this pull request
Apr 8, 2017
brianmhunt
added a commit
to knockout/tko
that referenced
this pull request
Apr 8, 2017
brianmhunt
added a commit
to knockout/tko
that referenced
this pull request
May 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The observableArray did leak the last value held by the observable when
subscribing for array change events, and then disposing the subscription.
The vlaue was being held by the closure held by the
arrayChangeSubscription. Setting it to null allows the GC to collect the
closure and the previousContents variable.
This commit fixes #2216