Skip to content

Commit

Permalink
fix: Retain property order when writing changes to package.json (#75)
Browse files Browse the repository at this point in the history
* feat: Retain json order

* chore: Remove test_ prefix from JSON order test
  • Loading branch information
z-triax committed Feb 26, 2021
1 parent b5374d3 commit 49d23da
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 1 deletion.
1 change: 1 addition & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ color-eyre = "0.5.10"
console = "0.13.0"
dialoguer = "0.7.1"
toml = "0.5.8"
serde_json = "1.0.63"
serde_json = { version = "1.0.63", features = ["preserve_order"] }
git2 = "0.13.17"
regex = "1.4.3"
semver = "0.11.0"
Expand Down
21 changes: 21 additions & 0 deletions src/package_json.rs
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,27 @@ mod tests {
let expected = r###"{
"name": "tester",
"version": "1.2.3-rc.4"
}"###
.to_string();
assert_eq!(std::fs::read_to_string(file).unwrap(), expected);
}

#[test]
fn retain_property_order() {
let file = NamedTempFile::new().unwrap();
let content = r###"{
"name": "tester",
"version": "0.1.0-rc.0",
"dependencies": {}
}"###;
std::fs::write(&file, content).unwrap();

set_version(&file, "1.2.3-rc.4").unwrap();

let expected = r###"{
"name": "tester",
"version": "1.2.3-rc.4",
"dependencies": {}
}"###
.to_string();
assert_eq!(std::fs::read_to_string(file).unwrap(), expected);
Expand Down

0 comments on commit 49d23da

Please sign in to comment.