feat: Retain json property order #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
dbanty
approved these changes
Feb 26, 2021
src/package_json.rs
Outdated
| } | ||
|
|
||
| #[test] | ||
| fn test_retain_property_order() { |
There was a problem hiding this comment.
I assume my prefixing of functions with test_ is just a habit from Python and not required here. We may be able to omit that?
There was a problem hiding this comment.
Yeah, I believe it's redundant. We already know it's a test, so the test_ prefix isn't adding any value.
@dbanty Do you want me to remove that in this PR, or would you rather we remove all of them in a separate PR?
There was a problem hiding this comment.
I think we should address them as we encounter them, so swap it out here before we merge.
dbanty
approved these changes
Feb 26, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR retains the order of properties in a JSON file.
Currently, Dobby will alphabetize JSON properties, which means updating a
package.jsonversion will result in the package and version being placed below a long list of dependencies and dev-dependencies.Workflows without a clean way to handle develop and release branches can run into issues when the standard/default order of
package.jsonproperties is rearranged in a single branch.