alpine reports a width of 0 for process.stdout.getWindowSize[0]

[bcoe]

When running through docker exec the Alpine OS reports process.stdout.getWindowSize[0] = 0, this in turn breaks the upstream inquirer dependency like so:

https://gist.github.com/bcoe/6bc16d0dbe5190b8d302

It seems appropriate to instead use the default value if a terminal width of 0 is reported.

[knownasilya]

Thoughts on semver for this change? It almost seems like a breaking change..

[bcoe]

@knownasilya great question, what do you think @SBoudrias? seems like we could go one of two ways:

1. stick with having upstream libraries opt to use a default value if process.stdout.getWindowSize() reports 0.
2. perhaps call this a major change as @knownasilya suggests, and change the contract of the API slightly.

From my point of view, 0 being returned felt like unexpected behavior, at the same time it's what process.stdout.getWindowSize() reported.

[SBoudrias]

Yeah, having 0 returned looks like a bug to me too.

@knownasilya can you expand your though as to why this would be a breaking change?

[knownasilya]

@SBoudrias mainly because consumers have expected it to be zero if all fallbacks fail (or return 0), but maybe 0 is never a desired value so it would technically be an enhancement.

[bcoe]

@knownasilya thanks for being so receptive to a patch 👍

[SBoudrias]

@knownasilya oh, I was confused because I though that was a discussion on the Inquirer repo.

So yeah, that looks like major bump worthy for cli-width.

[knownasilya]

Released as 1.1.1

[knownasilya]

So yeah, that looks like major bump worthy for cli-width.

Too late ;) I guess we'll see if anyone complains.

[bcoe]

@knownasilya but semver!

I think you'll probably be okay, it looks like cli-width's dependencies are mostly inquirer, and forks of inquirer:

[knownasilya]

Semver is very subjective

[knownasilya]

@bcoe I can add you as a collaborator so we can share the blame 😉