Use idiomatic Ember in autosubscribe mixin. #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to mutate the instance in `init` when we can just call `_super` from the methods themselves. This also fixes a bug where including this mixin would make the return value of `beforeModel` not properly block on a promise.
|
Failing tests were introduced prior to this change, see #13 for details. |
| var paramsRelay = this.get('paramsRelay'); | ||
| var params = this.paramsFor(this.routeName); | ||
| beforeModel() { | ||
| var paramsRelay = this.get('paramsRelay'); |
|
Sweet, thanks! I feel better already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to mutate the instance in
initwhen we can just call_superfrom the methods themselves.This also fixes two bugs when including this mixin:
beforeModelwould no longer block properly when a promise was returnedFunction.prototype.bindis not present in PhantomJS 1.9