-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#478 API crashes on 2nd render() call #994
Conversation
Pull Request Test Coverage Report for Build 1103
💛 - Coveralls |
Is there any way we could set up a test for this? Either unit or e2e... |
I have looked a bit into it, the problem is that we don't have the real document object at hand and therefore the d3.select(...).node() function doesn't exist. At the moment, there don't seem to be tests for the render(), at least no unit-tests. I can give it another look and if unit doesn't work out, add something to the e2e tests. |
Pending confirmation of the person who had the issue assigned to them. |
Your pr includes a commit from knsv about font configuration stuff, could you rebase your branch/cherrypick the relevant commit and create a new branch from |
OK sure, no problem |
This could be related to the commit of knsv regarding font size configuration that you included in this pr. It needs to be removed from this pr. |
- remove element from DOM before rendering to avoid conflicts in case of rerendering
- add e2e test for (re)rendering by api
The issue with the clipped text has to do with different styling applied during rendering compared with font applied when the graph is put in to place after rendering. The font-family fix should handle that problem, and has just been merged to develop. I have reviewed this and will merge it. My only concern is if there are some use-case where this might break some integration... |
There might be cases that rely on the current behavior but I would consider that as a misuse of the functionality. |
Merging but it will not be inkclud in 8.4.0. next release though. |
Resolves #478
Remove element from DOM before rendering to avoid conflicts in case of rerendering