Unicode 9.0 support - regenerate UNF tables and test data #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the changes have been accepted upstream. |
|
Done in 1033f48, thanks! |
|
Oops, I didn't realize this was a PR, went ahead and imported the files myself. I've added a merge commit for future reference. |
|
No problem, thanks for updating it! This is by far the fastest normalization gem so it's nice that it supports 9.0 now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cloned the base
unfproject, updated the Unicode source files and regeneratednormalization-test.txtfrom official Unicode 9.0 data (CompositionExclusions.txtDerivedNormalizationProps.txtUnicodeData.txtNormalizationTest.txt), and regenerated the definitions and tables using the lisp utilities.Here I've provided a PR containing the new Unicode 9.0-compatible
table.hhandnormalization-test.txtin the formunfexpects. It passes all of the tests included (18,722 entries in the new 9.0 test, up from 18,136 inmaster), and I have double-checked (with some benchmarking code from another normalization gem of mine) that this also passes a test using the unmodified officialNormalizationTest.txt.