-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement CI tests as xtask #393
Conversation
Co-authored-by: Johann Hemmann <johann.hemmann@code.berlin>
Co-authored-by: Johann Hemmann <johann.hemmann@code.berlin>
Co-authored-by: Johann Hemmann <johann.hemmann@code.berlin>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked if you missed to transfer any tests, but seems good to me.
fn test_single_snapshot
looks a bit messy to me, but from what I understand it does the same as firmware/qemu/test.sh
.
One question I am unsure about: Why is the --deny-warnings
only looked at in test_host
and not the other tests as well?
|
||
let mut features_map = HashMap::new(); | ||
features_map.insert("alloc", "alloc"); | ||
let no_features = ""; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const
🎉
Co-authored-by: Johann Hemmann <johann.hemmann@code.berlin>
Co-authored-by: Johann Hemmann <johann.hemmann@code.berlin>
@jonas-schievink what do you think? |
I don't think there was a particular reason we did this, but if there's a |
I don't really question the existence of the cmdline-arg, but rather why it is only taken into account for some tests and not also e.g. the |
Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the test.sh
and as far as I could understand you translated it properly. Can we delete the old file then?
Also I discovered another small nit while looking through the code xD
Co-authored-by: Johann Hemmann <johann.hemmann@code.berlin>
…to issue-336-ci-xtasks
… on macos because one platform is enough
bors r+ |
Build succeeded: |
🎉 |
this xtask implementation fixes #366 and
test-all
,test-host
,test-cross
etc.-k
switch to keep targets that were installed as required dependencynot done:
libusb
(out of scope, IMO)