Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #536 - add help for format string parsing error #735

Merged
merged 4 commits into from
Mar 10, 2023
Merged

Fix #536 - add help for format string parsing error #735

merged 4 commits into from
Mar 10, 2023

Conversation

jonathanpallant
Copy link
Contributor

@jonathanpallant jonathanpallant commented Mar 8, 2023 •
edited
Loading

  1. Replaces Cow<str> with an enum Error to accurately describe the parse error
  2. Uses thiserror to convert the Error enum into strings, which match the strings previously returned from the parse function
  3. Uses that enum to add help text for Error::UnknownDisplayHint.

Closes #536

@jonathanpallant
Adds defmt_parser::Error
b8220f1 
Uses `thiserror` to convert the `Error` enum into strings, which match the strings previously returned from the `parse` function.
@jonathanpallant
Uses the new Error enum to print help text.
9d2bfde 
Adds help text for Error::UnknownDisplayHint.

Closes #536
Urhengulas
Urhengulas approved these changes Mar 10, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
macros/src/function_like/println.rs Outdated Show resolved Hide resolved
@Urhengulas
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 10, 2023

Build succeeded:

@bors bors bot merged commit d409209 into main Mar 10, 2023
@bors bors bot deleted the fix-536-format-string-parser-error branch March 10, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Urhengulas Urhengulas Urhengulas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

format string parser error should point to the docs
2 participants
@jonathanpallant @Urhengulas