This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
Fix fn round_up.
#330
Merged
Fix fn round_up.
#330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was hardcoding `k` as `4`. This PR changes the fn to actually use `k`. This resultet in no problem so far, because it was only used with `k=4`.
Urhengulas
requested review from
japaric and
justahero
and removed request for
japaric
justahero
reviewed
Jul 15, 2022
|
bors r=justahero |
|
Build succeeded: |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was hardcoding
kas4. This PR changes the fn to actually usek.This resultet in no problem so far, because it was only used with
k=4.