Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do elli depend on inets? #109

Closed
cvik opened this issue Dec 6, 2017 · 3 comments
Closed

Why do elli depend on inets? #109

cvik opened this issue Dec 6, 2017 · 3 comments

Comments

@cvik
Copy link

cvik commented Dec 6, 2017

Elli starts inets if you run application:ensure_all_started(elli), yet inets isn't used anywhere.

@andreashasse
Copy link
Collaborator

Hi, Elli uses http_uri:decode/1 which is a part of inets. http_uri:decode/1 does not rely on the inets application being started so one could argue that it should be moved to included_applications. Would that work for you?

@cvik
Copy link
Author

cvik commented Dec 7, 2017

True, didn't think to check for that. That solution absolutely works for me in the short run. 👍

I just can't help the feeling that it is kind of dirty to pull in a library containing another full http-server, http-client and ftp-client, just to call the one function. Have you considered just copying that function into elli or write your own version? Would be happy to supply a PR if you want to outsource that. :)

@knutin
Copy link
Owner

knutin commented Dec 13, 2017 via email

@cvik cvik closed this as completed Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants