Add base_image provider setting. #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a base_image provider setting in order to allow setting a global base image default for ko. Signed-off-by: Billy Lynch <billy@chainguard.dev>
wlynch
force-pushed
the
base-image-default
branch
from
e024ab7
to
1c402f6
Compare
imjasonh
reviewed
Apr 3, 2024
imjasonh
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a base_image provider setting in order to allow setting a global base image default for ko.
This unfortunately requires unsetting the default base image as the default in the resource args, since this is indistinguishable from whether the user set the field or not. :( (if there's a better way to do this lmk!)