Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove fs-cp? #19

Closed
tunnckoCore opened this issue Apr 5, 2016 · 4 comments · Fixed by #54
Closed

remove fs-cp? #19

tunnckoCore opened this issue Apr 5, 2016 · 4 comments · Fixed by #54

Comments

@tunnckoCore
Copy link
Contributor

Why it is there? Everyone can add it and use it directly, if he want it. This also blocks using this package in plugins, like

var bodyParsers = require('koa-body-parsers')
var koa = require('koa')
var app = koa()

app.use(function * () {
  bodyParsers(this)
})
.use(function * () {
  this.body = yield this.request.json()
})

for example - i need it this way, because I'm going to use it in plugin that wraps these things.

Fails to set .save on app.context

TypeError: Cannot set property 'save' of undefined
      at /home/charlike/dev/final/koa-better-body/node_modules/koa-body-parsers/index.js:18:22
      at Array.forEach (native)
      at Function.module.exports.Object.keys.forEach.Object.keys.forEach.Object.keys.forEach (/home/charlike/dev/final/koa-better-body/node_modules/koa-body-parsers/index.js:17:24)
      at Object.plugin (/home/charlike/dev/final/koa-better-body/index.js:21:11)
      at next (native)
      at Object.<anonymous> (/home/charlike/dev/final/koa-better-body/node_modules/koa-compose/index.js:28:12)
      at next (native)
      at onFulfilled (/home/charlike/dev/final/koa-better-body/node_modules/co/index.js:65:19)
      at /home/charlike/dev/final/koa-better-body/node_modules/co/index.js:54:5
      at Object.co (/home/charlike/dev/final/koa-better-body/node_modules/co/index.js:50:10)
@jonathanong
Copy link
Member

i don't mind. just needs to be a major version bump

@tunnckoCore
Copy link
Contributor Author

Great, want PR?

@tunnckoCore
Copy link
Contributor Author

ping?

@haoxins
Copy link
Member

haoxins commented Apr 12, 2016

@tunnckoCore Submit a PR?

tunnckoCore pushed a commit to tunnckoCore/body-parsers that referenced this issue Oct 12, 2019
It's 2019 and still failing. resolves koajs#19 and koajs#20
jonathanong pushed a commit that referenced this issue Feb 25, 2024
* remove fs-cp

It's 2019 and still failing. resolves #19 and #20

* chore: remove fs-cp dep

---------

Co-authored-by: Charlike Mike Reagent <ceo@tunnckocore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants