Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove fs-cp dependency #20

Closed
wants to merge 2 commits into from
Closed

Conversation

tunnckoCore
Copy link
Contributor

resolves #19

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.111% when pulling b515504 on tunnckoCore:master into 364bd29 on koajs:master.

@haoxins
Copy link
Member

haoxins commented Apr 15, 2016

@tunnckoCore I only use node@4+, can you split support node@0.12 to another PR?

@jonathanong what's your option for 0.12?

@tunnckoCore
Copy link
Contributor Author

tunnckoCore commented Apr 15, 2016

I'm using this package in upcoming v2 (in a bit, I'm waiting this pr) of koa-better-body. And we need/want have support for 0.12. It's not serious to drop support for 0.12 because of the few variables and one arrow function. I hate such forces and non-logical moves - i'm not talking for this exactly case, in general. They doesn't do so special things and not worth using them here currently.

I was not going to add this commit, but it breaks my builds, so it's needed to me. If not accept this PR, close and I'll still use the fixed fork.

Cheers,
Charlike!

@haoxins
Copy link
Member

haoxins commented Apr 15, 2016

OK, but we can use const on 0.12, right? Why changed to var?

@tunnckoCore
Copy link
Contributor Author

tunnckoCore commented Apr 15, 2016

Actually, yes we can. Maybe I didn't realize that I'm changing them or my habits, nevermind. What's the point using const exactly, currently here? There's no point.

I'm against using features and things (in general) because they are just there and because they exist, sorry.

@haoxins
Copy link
Member

haoxins commented Apr 16, 2016

What's the point using const exactly

  1. no need revert const to var again. It's noisy
  2. they are constant indeed

@jonathanong
Copy link
Member

won't be merging this PR in this form. please feel free to open a new one!

@jonathanong jonathanong closed this Feb 9, 2017
tunnckoCore pushed a commit to tunnckoCore/body-parsers that referenced this pull request Oct 12, 2019
It's 2019 and still failing. resolves koajs#19 and koajs#20
jonathanong pushed a commit that referenced this pull request Feb 25, 2024
* remove fs-cp

It's 2019 and still failing. resolves #19 and #20

* chore: remove fs-cp dep

---------

Co-authored-by: Charlike Mike Reagent <ceo@tunnckocore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove fs-cp?
4 participants