Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm install koa-better-body failing this morning #58

Closed
MichaelCation opened this issue Oct 8, 2019 · 7 comments
Closed

npm install koa-better-body failing this morning #58

MichaelCation opened this issue Oct 8, 2019 · 7 comments
Labels
duplicate This issue or pull request topic/problem already exists. Pkg: koa-better-body Priority: Medium This issue may be useful, and needs some attention. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: Awaiting Response Waiting author or someone to respond to question or clarification Status: Completed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity, without a functionality.

Comments

@MichaelCation
Copy link

When I ran "npm install koa-better-body" on a clean machine this morning it failed with "npm ERR! enoent undefined ls-remote -h -t https://github.com/tunnckoCore/body-parsers.git"

Perhaps "body-parsers.git" should be "koa-body-parsers.git" instead?
@tunnckoCore
Copy link
Owner

Oh, sorry for the delay. I was offline whole week.

I'll check.

@tunnckoCore
Copy link
Owner

tunnckoCore commented Oct 12, 2019 •
edited

No, it's correct. https://github.com/tunnckoCore/body-parsers it's an old fork...
The thing is I'm not sure why it was and what is changed between the original and the fork.

I can't reproduce. To me, it doesn't fail both with Yarn and npm. Do you have git installed?

GitHub
collection of koa body parsers. Contribute to tunnckoCore/body-parsers development by creating an account on GitHub.

@tunnckoCore
Copy link
Owner

tunnckoCore commented Oct 12, 2019 •
edited

Oh, I remember why is the fork. The main reason.

koajs/body-parsers#19
koajs/body-parsers#20

So, suggested a PR there koajs/body-parsers#54, again.

@tunnckoCore
Copy link
Owner

tunnckoCore commented Oct 12, 2019 •
edited

@MichaelCation probably your server where you are installing doesn't have git installed?

Just published 3.1.3. I'm assuming that when it is just username/repo instead of git+ or git:// it will work, because in Yarn lockfile can be seen a change to use something called "codeload.github.com", so it will download it from github and no need for git.

@tunnckoCore tunnckoCore added duplicate This issue or pull request topic/problem already exists. Priority: Medium This issue may be useful, and needs some attention. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: Await Response Status: Completed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity, without a functionality. and removed bug labels Oct 12, 2019
@tunnckoCore
Copy link
Owner

tunnckoCore commented Oct 18, 2019 •
edited

Probably similar to #36 / #35. We'll wait response. :)

@tunnckoCore
Copy link
Owner

@MichaelCation is it fixed? Try v3.1+, best 3.1.13

@tunnckoCore tunnckoCore added the Status: Awaiting Response Waiting author or someone to respond to question or clarification label Oct 24, 2019
@tunnckoCore
Copy link
Owner

Closing. Please try newer versions or report again with new issue here.

@snyk-bot snyk-bot mentioned this issue Jul 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request topic/problem already exists. Pkg: koa-better-body Priority: Medium This issue may be useful, and needs some attention. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: Awaiting Response Waiting author or someone to respond to question or clarification Status: Completed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity, without a functionality.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MichaelCation @tunnckoCore