We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In __tests__.index.js there is a section:
__tests__.index.js
it('should support Z_SYNC_FLUSH', (done) => { const app = new Koa() app.use(compress({ flush: zlib.constants.Z_SYNC_FLUSH })) // and so on })
Is flush really a top-level option? Or should it be:
flush
app.use(compress({ gzip: { // or deflate? flush: zlib.constants.Z_SYNC_FLUSH } }))
The test succeeds anyway: with the existing code, with added gzip, even when the flush line is commented out.
gzip
I don't know what effects should be tested but it looks like they are not observed. I think it should be clarified and the test updated.
The text was updated successfully, but these errors were encountered:
you're right. the test doesn't actually do anything, so I'll delete it. feel free to make a new test if you would like.
Sorry, something went wrong.
9c85e57
No branches or pull requests
In
__tests__.index.js
there is a section:Is
flush
really a top-level option? Or should it be:The test succeeds anyway: with the existing code, with added
gzip
, even when theflush
line is commented out.I don't know what effects should be tested but it looks like they are not observed. I think it should be clarified and the test updated.
The text was updated successfully, but these errors were encountered: