Modren koa-compress 07/2021 #135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3imed-jaberi
force-pushed
the
modren-compress-07-2021
branch
2 times, most recently
from
b90259b
to
779c839
Compare
3imed-jaberi
force-pushed
the
modren-compress-07-2021
branch
from
779c839
to
e10ec7c
Compare
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 81 81
Branches 30 31 +1
=========================================
Hits 81 81
Continue to review full report at Codecov.
|
jonathanong
reviewed
Aug 18, 2021
| @@ -3,92 +3,92 @@ | |||
| const errors = require('http-errors') | |||
| const zlib = require('zlib') | |||
|
|
|||
| module.exports = Encodings | |||
| class Encodings { | |||
There was a problem hiding this comment.
sorry, there's too much going on here. Better to make more smaller PRs
There was a problem hiding this comment.
Done, this is smaller #137 and it was taken all latest updates in consideration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #105, #123
close #127 #134