add test: req.host should work with IPv6 Host #875
Conversation
Current coverage is 100% (diff: 100%)@@ master #875 diff @@
====================================
Files 4 4
Lines 417 420 +3
Methods 81 81
Messages 0 0
Branches 102 104 +2
====================================
+ Hits 417 420 +3
Misses 0 0
Partials 0 0
|
|
@dougwilson what do you think? i haven't seen ipv6 host names in the wild |
|
The |
| req.header.host = '[::1]:3000'; | ||
| assert.equal(req.hostname, '[::1]'); | ||
| }) | ||
|
|
There was a problem hiding this comment.
What should req.hostname be if req.host is [::1] without the port? Or is req.host guaranteed with port attached such as [::1]:80?
Otherwise, if req.host were [::1], this req.hostname would be [::.
There was a problem hiding this comment.
Good catch. Change needs to take into account that port is optional.
There was a problem hiding this comment.
Can we convert the ipv6 address to real one? [::1]:3000 look like not real.
There was a problem hiding this comment.
::1 is the short hand for the main loopback address (the IPv6 version of 127.0.0.1).
No description provided.