Add ContextStore #80

shaoshuai0102 · 2017-06-14T11:04:33Z

No description provided.

coveralls · 2017-06-14T11:06:29Z

Coverage decreased (-0.5%) to 99.468% when pulling 65e4f3d on shaoshuai0102:feat-ctx-store-for-4.x into ae21f52 on koajs:4.x.

coveralls · 2017-06-14T11:06:29Z

Coverage decreased (-0.5%) to 99.468% when pulling 65e4f3d on shaoshuai0102:feat-ctx-store-for-4.x into ae21f52 on koajs:4.x.

coveralls · 2017-06-14T11:18:25Z

Coverage remained the same at 100.0% when pulling 89d5c14 on shaoshuai0102:feat-ctx-store-for-4.x into ae21f52 on koajs:4.x.

shaoshuai0102 · 2017-06-14T11:38:19Z

ping @dead-horse

coveralls · 2017-06-14T11:40:24Z

Coverage remained the same at 100.0% when pulling 1d59173 on shaoshuai0102:feat-ctx-store-for-4.x into ae21f52 on koajs:4.x.

coveralls · 2017-06-14T11:44:46Z

Coverage remained the same at 100.0% when pulling e008b72 on shaoshuai0102:feat-ctx-store-for-4.x into ae21f52 on koajs:4.x.

coveralls · 2017-06-14T11:44:46Z

Coverage remained the same at 100.0% when pulling e008b72 on shaoshuai0102:feat-ctx-store-for-4.x into ae21f52 on koajs:4.x.

popomore · 2017-06-14T11:53:03Z

index.js

-    assert(typeof opts.store.set === 'function', 'store.set must be function');
-    assert(typeof opts.store.destroy === 'function', 'store.destroy must be function');
+  if (opts.ContextStore) {
+    assert(typeof opts.ContextStore === 'function', 'ContextStore must be a function');


And check ContextStore.prototype[method]

only check ContextStore.prototype[method] once

popomore · 2017-06-14T11:54:29Z

index.js

@@ -78,10 +78,8 @@ function formatOpts(opts) {
    opts.decode = util.decode;
  }

-  if (opts.store) {


Should check store first when it's specified.

fengmk2 · 2017-06-14T15:01:31Z

lib/context.js

+    if (this.store) {
+      assert(typeof this.store.get === 'function', 'store.get must be function');
+      assert(typeof this.store.set === 'function', 'store.set must be function');
+      assert(typeof this.store.destroy === 'function', 'store.destroy must be function');


No need to check store type on every request.
Only assert once at the beginning.

fengmk2 · 2017-06-14T15:03:01Z

test/store.test.js

@@ -6,635 +6,654 @@ const should = require('should');
 const mm = require('mm');
 const session = require('..');
 const store = require('./store');
+const ContextStore = require('./context_store');


keep the old test file and add a new one for context store.

shaoshuai0102 · 2017-06-15T03:15:30Z

All issues settled

coveralls · 2017-06-15T03:15:32Z

Coverage remained the same at 100.0% when pulling 4703d0b on shaoshuai0102:feat-ctx-store-for-4.x into ae21f52 on koajs:4.x.

dead-horse · 2017-06-15T03:26:57Z

should introduce ContextStore in readme

shaoshuai0102 · 2017-06-15T03:32:33Z

Readme.md

@@ -118,6 +118,8 @@ app.use(convert(session(app)));

  Once you passed `options.store`, session is strong dependent on your external store, you can't access session if your external store is down. **Use external session stores only if necessary, avoid use session as a cache, keep session lean and stored by cookie!**

+  If your session store requires data or utilities from context, `opts.ContextStore` is alse supported. `ContextStore` must be a class which claims three instance methods demonstrated above. `new ContextStore(ctx)` will be executed on every request.


coveralls · 2017-06-15T03:34:05Z

Coverage remained the same at 100.0% when pulling d86f898 on shaoshuai0102:feat-ctx-store-for-4.x into ae21f52 on koajs:4.x.

dead-horse · 2017-06-15T03:50:54Z

LGTM

dead-horse · 2017-06-15T04:02:42Z

@shaoshuai0102 please pick this feature to master branch

shaoshuai0102 · 2017-06-15T06:17:53Z

publish a version pls.

I will pick it to master

shaoshuai0102 · 2017-06-15T06:37:16Z

4.2.0

shaoshuai0102 force-pushed the feat-ctx-store-for-4.x branch from 65e4f3d to 89d5c14 Compare June 14, 2017 11:16

shaoshuai0102 force-pushed the feat-ctx-store-for-4.x branch from 89d5c14 to 1d59173 Compare June 14, 2017 11:37

shaoshuai0102 changed the title ~~[WIP] Add ContextStore~~ Add ContextStore Jun 14, 2017

shaoshuai0102 force-pushed the feat-ctx-store-for-4.x branch from 1d59173 to e008b72 Compare June 14, 2017 11:42

popomore reviewed Jun 14, 2017

View reviewed changes

fengmk2 reviewed Jun 14, 2017

View reviewed changes

shaoshuai0102 force-pushed the feat-ctx-store-for-4.x branch from e008b72 to 4703d0b Compare June 15, 2017 03:13

feat: ContextStore

d86f898

shaoshuai0102 force-pushed the feat-ctx-store-for-4.x branch from 4703d0b to d86f898 Compare June 15, 2017 03:32

shaoshuai0102 commented Jun 15, 2017

View reviewed changes

dead-horse approved these changes Jun 15, 2017

View reviewed changes

dead-horse merged commit dd2fa4a into koajs:4.x Jun 15, 2017

shaoshuai0102 deleted the feat-ctx-store-for-4.x branch June 15, 2017 06:17

shaoshuai0102 mentioned this pull request Jun 15, 2017

feat: ContextStore #81

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ContextStore #80

Add ContextStore #80

shaoshuai0102 commented Jun 14, 2017

coveralls commented Jun 14, 2017 •

edited

Loading

coveralls commented Jun 14, 2017

coveralls commented Jun 14, 2017 •

edited

Loading

shaoshuai0102 commented Jun 14, 2017

coveralls commented Jun 14, 2017 •

edited

Loading

coveralls commented Jun 14, 2017 •

edited

Loading

coveralls commented Jun 14, 2017

popomore Jun 14, 2017

popomore Jun 14, 2017

fengmk2 Jun 14, 2017

fengmk2 Jun 14, 2017

popomore Jun 14, 2017

fengmk2 Jun 14, 2017

fengmk2 Jun 14, 2017

shaoshuai0102 commented Jun 15, 2017

coveralls commented Jun 15, 2017 •

edited

Loading

dead-horse commented Jun 15, 2017

shaoshuai0102 Jun 15, 2017

coveralls commented Jun 15, 2017 •

edited

Loading

dead-horse commented Jun 15, 2017

dead-horse commented Jun 15, 2017

shaoshuai0102 commented Jun 15, 2017

shaoshuai0102 commented Jun 15, 2017

		@@ -118,6 +118,8 @@ app.use(convert(session(app)));

		Once you passed `options.store`, session is strong dependent on your external store, you can't access session if your external store is down. Use external session stores only if necessary, avoid use session as a cache, keep session lean and stored by cookie!

		If your session store requires data or utilities from context, `opts.ContextStore` is alse supported. `ContextStore` must be a class which claims three instance methods demonstrated above. `new ContextStore(ctx)` will be executed on every request.

Add ContextStore #80

Add ContextStore #80

Conversation

shaoshuai0102 commented Jun 14, 2017

coveralls commented Jun 14, 2017 • edited Loading

coveralls commented Jun 14, 2017

coveralls commented Jun 14, 2017 • edited Loading

shaoshuai0102 commented Jun 14, 2017

coveralls commented Jun 14, 2017 • edited Loading

coveralls commented Jun 14, 2017 • edited Loading

coveralls commented Jun 14, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shaoshuai0102 commented Jun 15, 2017

coveralls commented Jun 15, 2017 • edited Loading

dead-horse commented Jun 15, 2017

Choose a reason for hiding this comment

coveralls commented Jun 15, 2017 • edited Loading

dead-horse commented Jun 15, 2017

dead-horse commented Jun 15, 2017

shaoshuai0102 commented Jun 15, 2017

shaoshuai0102 commented Jun 15, 2017

coveralls commented Jun 14, 2017 •

edited

Loading

coveralls commented Jun 14, 2017 •

edited

Loading

coveralls commented Jun 14, 2017 •

edited

Loading

coveralls commented Jun 14, 2017 •

edited

Loading

coveralls commented Jun 15, 2017 •

edited

Loading

coveralls commented Jun 15, 2017 •

edited

Loading