Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cart-box also for ajax-view detail product pages #11

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Update cart-box also for ajax-view detail product pages #11

merged 1 commit into from
Jan 15, 2019

Conversation

fraxachun
Copy link
Contributor

No description provided.

@fraxachun fraxachun mentioned this pull request Jan 11, 2019
Merged
@nsams
Copy link
Member

nsams commented Jan 11, 2019

  • onReady.onRender dürfen nicht verschachtelt sein
  • global auf alle .kwfUp-addToCartForm .kwfUp-formContainer schauen holt auch die von anderen komponenten. Das sollte nicht sein, die sollen das selbst für sich machen.

@fraxachun
Copy link
Contributor Author

@nsams Jetzt sollte es sauberer gelöst sein. Auch hier: koala-framework/koala-framework#934

@nsams
Copy link
Member

nsams commented Jan 14, 2019

hm, du hast keine änderung gepushed...

@fraxachun
Copy link
Contributor Author

ups, aber jetzt

@fraxachun fraxachun merged commit 6aa5965 into 1.0 Jan 15, 2019
@fraxachun fraxachun deleted the update-add-to-cart-box branch January 15, 2019 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsams nsams nsams approved these changes

@kaufmo kaufmo kaufmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fraxachun @nsams @kaufmo