Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High CPU usage after scan has finished #51

Closed
MCOfficer opened this issue Nov 30, 2020 · 9 comments
Closed

High CPU usage after scan has finished #51

MCOfficer opened this issue Nov 30, 2020 · 9 comments

Comments

@MCOfficer
Copy link
Contributor

Describe the bug
While waiting for the final keystore, ODD uses a lot of CPU.

To Reproduce
Steps to reproduce the behavior:

  1. Run an OD scan
  2. Wait for Finished indexing!
  3. Check CPU usage

Expected behavior
ODD should be relatively idle. The loop to read the next keystroke (the only reasonable explanation) shouldn't consume as much CPU.

Screenshots

image

Desktop (please complete the following information):

  • OS: Ubuntu 18.0.5
  • Version v1.9.1.0 self-contained
@KoalaBear84
Copy link
Owner

So I should remove the cryptominer?

@KoalaBear84
Copy link
Owner

KoalaBear84 commented Nov 30, 2020

Could be that you introduced it, because there is no waiting in the non-redirected console code 😂

#44 

I'll look into it when I have time :)

@MCOfficer
Copy link
Contributor Author

Looks like it 😅 I'm not sure if Console.KeyAvailable will still work if the key is pressed during the inevitable Thread.sleep (or whatever C#'s equivalent is).

@KoalaBear84
Copy link
Owner

KoalaBear84 commented Dec 2, 2020

I do not know either, added possible fix, waiting for the #52 and will release new builds to test both of it :)

I'm curious if calling softprops/action-gh-release@v1 for all will not create a release for every matrix :)

@KoalaBear84 KoalaBear84 reopened this Dec 2, 2020
@MCOfficer
Copy link
Contributor Author

MCOfficer commented Dec 3, 2020

It seems that this has made ODD ignore the final keystroke on 1.9.2.0, but at least the CPU is good i guess :D . Can you confirm that?

@KoalaBear84
Copy link
Owner

Hmm, could be. Currently no time, will try to check this afternoon.

@MCOfficer
Copy link
Contributor Author

MCOfficer commented Dec 3, 2020

Hm, i can't reproduce the keystroke issue on my server... might've been an oddity with my terminal.

@KoalaBear84
Copy link
Owner

Reproducible?

@MCOfficer
Copy link
Contributor Author

I've never encountered it since, so no.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants