Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

klone CFLAGS passed down to libu configure #5

Open
thomas-fossati opened this issue Mar 22, 2017 · 0 comments
Open

klone CFLAGS passed down to libu configure #5

thomas-fossati opened this issue Mar 22, 2017 · 0 comments

Comments

@thomas-fossati
Copy link

I'm not sure this is a bug per se, but certainly is a dangerous feature.

What can happen -- actually did happen, see #4 -- is that if CFLAGS have side effects (e.g., defining / undefining macros) the fact that klone's CFLAGS are used in libu configure checks can end up subverting settings. In #4 , makl_checkinline fails in klone's configure and adds -Dinline= to CFLAGS. Then libu configure is run and its own makl_checkinline is invoked which now passes because in the meantime the inline keyword has been suppressed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant