Use config secret key by default

kobinpy · Jan 1, 2017 · 40a9a92 · 40a9a92
1 parent 959a02d
commit 40a9a92
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/kobin/environs.py b/kobin/environs.py
@@ -292,6 +292,9 @@ def headerlist(self):
 
     def set_cookie(self, key, value, expires=None, max_age=None, path='/',
                    secret=None, digestmod=hashlib.sha256):
+        from kobin.app import current_config
+        if secret is None:
+            secret = current_config().get('SECRET_KEY')
         if secret:
             if isinstance(secret, str):
                 secret = secret.encode('utf-8')

diff --git a/tests/test_environs.py b/tests/test_environs.py
@@ -249,6 +249,15 @@ def test_get_cookie_with_secret(self):
         expected = 'bar'
         self.assertEqual(actual, expected)
 
+    @patch('kobin.app.current_config')
+    def test_set_cookie_with_secret_in_config(self, mock_current_config):
+        mock_current_config.return_value = Config(SECRET_KEY="secretkey")
+        response = BaseResponse()
+        response.set_cookie('foo', 'bar', path=None)
+        expected_set_cookie = ('Set-Cookie', 'foo="!VzhGFLGcW+5OMs1s4beLXaqFxAUwgHdWkH5fgapghoI='
+                                             '?gASVDwAAAAAAAACMA2Zvb5SMA2JhcpSGlC4="')
+        self.assertIn(expected_set_cookie, response.headerlist)
+
 
 class BaseResponseTests(TestCase):
     def test_constructor_body(self):