Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape quote during CSV exports by doubling it #194

Merged
merged 7 commits into from
Jan 17, 2019

Conversation

jnm
Copy link
Member

@jnm jnm commented Jan 16, 2019

Fixes #193. The long URL in the new test fixture is for the next bug that needs to be fixed 馃槈

@jnm jnm requested a review from noliveleger January 16, 2019 05:30
@jnm
Copy link
Member Author

jnm commented Jan 16, 2019

I've upgraded some dependencies in an effort to get the Travis build to pass, but now I'm running up against z4r/python-coveralls#66. https://github.com/z4r/python-coveralls hasn't been updated in around 20 months; maybe it's a good time to switch to https://github.com/coveralls-clients/coveralls-python, which is actively developed.

@coveralls
Copy link

coveralls commented Jan 16, 2019

Coverage Status

Coverage increased (+0.02%) to 82.633% when pulling a18db35 on 193-csv-escape-quotes into 0a11fee on master.

@jnm jnm force-pushed the 193-csv-escape-quotes branch 2 times, most recently from 9994321 to 599817c Compare January 16, 2019 16:10
@noliveleger noliveleger merged commit f4918cd into master Jan 17, 2019
@jnm jnm deleted the 193-csv-escape-quotes branch December 3, 2020 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quotes are not escaped in CSV exports
3 participants