Speed up xlsx_to_dict_normal_sheet(), especially when many blank columns are present
#316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
especially when many blank columns are present
jnm
commented
Aug 25, 2023
| @@ -162,34 +161,35 @@ def xlsx_value_to_str(value): | |||
| return str(value).replace(chr(160), ' ') | |||
|
|
|||
| def xlsx_to_dict_normal_sheet(sheet): | |||
|
|
|||
| # Check for duplicate column headers | |||
There was a problem hiding this comment.
Removed comment because none of the code did anything about duplicate headers
jnm
commented
Aug 25, 2023
Comment on lines
-170
to
-171
| # xls file with 3 columns mostly have a 3 more columns that are | ||
| # blank by default or something, skip during check |
There was a problem hiding this comment.
Removed comment because none of the code did anything in particular with 3 columns
JacquelineMorrissette
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.