Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migration conflict caused by waiting too long #508

Merged
merged 1 commit into from
Jan 2, 2019

Conversation

jnm
Copy link
Member

@jnm jnm commented Dec 18, 2018

...to merge #395

@noliveleger, this is simple enough, but encountering this conflict makes me wonder if the dropping/adding done by #395 will cause downtime on large databases.

@jnm jnm requested a review from noliveleger December 18, 2018 08:00
@jnm jnm merged commit 568c7ae into master Jan 2, 2019
@jnm jnm deleted the pr-395-migration-conflict branch January 2, 2019 21:56
@noliveleger
Copy link
Contributor

noliveleger commented Jan 7, 2019

@jnm Even it has been already merged, I tested it. It took about 44 minutes to apply the migration and rebuild the index.
I'm gonna retry with CONCURRENTLY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants