Remove public access to project API endpoint #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noliveleger
force-pushed
the
block-api-form
branch
from
dd41295
to
b926f10
Compare
LMNTL
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
This works well in my testing! It might be good to update the Deprecation Notices section of README.md. But since the endpoints aren't being removed, just requiring authentication, I'm not convinced it's necessary. I'm approving 👍
XLSForm uploads were disabled in the UI on 14 June 2021, and #892 removes them from the API as well. Perform all form management through KPI instead.
|
Good idea. I did some work on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users cannot upload, update or delete projects with API
v1anymore.Additional info
KPI Kobocat proxy is still able to use it though. Unit tests have been updated accordingly.
Scripts / links which still point to this endpoint
/api/v1/forms/should now usehttps://[kpi]/api/v2/assets/instead.