Improve update_attachment_storage_bytes management command
#896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… managegment command
LMNTL
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Making a note based on some discussion that came up during review but is outside of this PR's scope:
UserProfile.attachment_storage_bytes doesn't get updated when an item goes into the Trash Bin - currently, it gets updated whenever the XForm is actually deleted. This means that it disagrees with the storage amount returned by /service_usage/, which doesn't include trashed forms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Return a more accurate global storage metric when user has no projects
Additional info
Add three new options to management command:
forceto recalculate counters for every user - even those already calculatedsyncto recalculate all the counters of users whose profile does not correspond with the projectsskip-lock-releaseto avoid release submission locks (useful (and faster) when all locks are already released)