Regroup storage counter calculation in the same DB transaction #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to keep counters update in the same transaction
noliveleger
force-pushed
the
regroup-attachment-signals
branch
from
5b47900
to
299fe25
Compare
LMNTL
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid discrepancy when something goes wrong (e.g. one counter is decreased but not the other)
Notes
Use
default_storage_classto get rid of the file on storage instead of letting the FileFieldmedia_filehandle it.As explained in the comments of this PR,
attachment.media_file.delete()could rise to a race condition on counter update.