Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing ZIP exports #901

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Fix failing ZIP exports #901

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e60e14e
Remove unuset imports
noliveleger Oct 18, 2023
90b106f
Use isinstance instead of issubclass to test inheritance of default_s…
noliveleger Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 2 additions & 3 deletions onadata/libs/utils/viewer_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,10 +193,9 @@ def no_seeking(*a, **kw):
# The default, file-system storage won't allow changing the `seek`
# attribute, which is fine because seeking on local files works
# perfectly anyway
storage_class = get_storage_class()
if not issubclass(storage_class, FileSystemStorage):
if not isinstance(default_storage, FileSystemStorage):
logging.warning(
f'{storage_class} may not be a local storage class, but '
f'{default_storage.__class__} may not be a local storage class, but '
f'disabling seeking failed: {e}'
)

Expand Down